Direct user to publish ./package/ directory instead of ./#7280
Merged
dummdidumm merged 4 commits intosveltejs:masterfrom Oct 17, 2022
Merged
Direct user to publish ./package/ directory instead of ./#7280dummdidumm merged 4 commits intosveltejs:masterfrom
./package/ directory instead of ./#7280dummdidumm merged 4 commits intosveltejs:masterfrom
Conversation
…posed to run: `npm publish package/`. However, I keep accidentally running `npm publish` (the wrong directory) out of habit, instead. With this change, when the user accidentally tries to publish the `./` directory, they will be directed to publish the `./package/` directory instead.
🦋 Changeset detectedLatest commit: eed3a68 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After running
svelte-package(viacreate-svelte), the user is supposed torun:
npm publish package/. However, it is easy to accidentally runnpm publishon the wrong directory out of habit. With this change,when the user accidentally tries to publish the
./directory, they will bedirected to publish the
./package/directory instead.In case it is useful, thanks.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0